Skip to content

Conversation

damabe
Copy link
Contributor

@damabe damabe commented Mar 16, 2019

Summary

Updating image file names and references to improve SEO.

Files #1463880

Contributes to #10839

@damabe damabe requested a review from Lxiamail as a code owner March 16, 2019 02:18
@damabe
Copy link
Contributor Author

damabe commented Mar 16, 2019

@mairaw This PR is ready for review. CATS report: https://contentqacats.azurewebsites.net/CheckResults/2019031600040/Report/

There are two image names identified by CATS as being too short. They should be handled at a later time as they are not part of the SEO image without hyphen work.

@mairaw mairaw added this to the March 2019 milestone Mar 18, 2019
Copy link
Contributor

@mairaw mairaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @damabe. Changes look good. Left a few comments for you to consider.

> In WCF, we show response messages being processed initially in a separate activity (Process message) before we correlate them to the corresponding Process Action activity that includes the request message, through a transfer. This happens for infrastructure messages and asynchronous requests and is due to the fact that we must inspect the message, read the activityId header, and identify the existing Process Action activity with that id to correlate to it. For synchronous requests, we are blocking for the response and hence know which Process action the response relates to.
![Using the Trace Viewer](../../../../../docs/framework/wcf/diagnostics/tracing/media/e2etrace4.gif "e2eTrace4")
WCF client activities listed by creation time (left panel) and their nested activities and traces (upper right panel)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move this sentence to a paragraph before the image like

"The following image shows..."

Otherwise, only screen readers will have this info.

The alt text could say Screenshot of Trace Viewer showing [WCF client activities listed by creation time.

Apply same feedback to the other images here too.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made this change. Will apply to other images here (and other PRs, as needed). On the alt text, if I add the text as you recommend, it ends up higher than the 70 character threshold. I modified to be <70. Please review and let me know if it is OK.

3. When the project is created, the Service1.xamlx file is opened in the designer as shown in the following illustration.

![The default workflow displayed in the designer](../../../../docs/framework/wcf/feature-details/media/defaultworkflowservice.JPG "DefaultWorkflowService")
![Screenshot that shows the default workflow in the designer.](./media/how-to-create-a-workflow-service-with-messaging-activities/default-workflow-service.jpg)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should specify what the screenshot is about in these alt texts

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mairaw I've updated this one and the next (Messaging tab > Messaging section) based on your feedback. I'm not sure if I should make additional changes to the alt text content in the rest of this article. It seems that's what you're asking me to do. I'm just not sure what to change them to. Please provide guidance and I'll make the changes.

@mairaw
Copy link
Contributor

mairaw commented Mar 22, 2019

Can you look at the requested changes here @damabe?

@damabe
Copy link
Contributor Author

damabe commented Mar 23, 2019

@mairaw Made the changes. Please review and provide feedback. Updated CATS: https://contentqacats.azurewebsites.net/CheckResults/2019032300028/Report/

Copy link
Contributor

@mairaw mairaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx @damabe!

@mairaw mairaw merged commit 38fc049 into dotnet:master Mar 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants