-
Notifications
You must be signed in to change notification settings - Fork 6k
SEOImages: User Story 1463880, Part 14 #11333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@mairaw This PR is ready for review. CATS report: https://contentqacats.azurewebsites.net/CheckResults/2019031600040/Report/ There are two image names identified by CATS as being too short. They should be handled at a later time as they are not part of the SEO image without hyphen work. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @damabe. Changes look good. Left a few comments for you to consider.
> In WCF, we show response messages being processed initially in a separate activity (Process message) before we correlate them to the corresponding Process Action activity that includes the request message, through a transfer. This happens for infrastructure messages and asynchronous requests and is due to the fact that we must inspect the message, read the activityId header, and identify the existing Process Action activity with that id to correlate to it. For synchronous requests, we are blocking for the response and hence know which Process action the response relates to. | ||
 | ||
WCF client activities listed by creation time (left panel) and their nested activities and traces (upper right panel) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Move this sentence to a paragraph before the image like
"The following image shows..."
Otherwise, only screen readers will have this info.
The alt text could say Screenshot of Trace Viewer showing [WCF client activities listed by creation time.
Apply same feedback to the other images here too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made this change. Will apply to other images here (and other PRs, as needed). On the alt text, if I add the text as you recommend, it ends up higher than the 70 character threshold. I modified to be <70. Please review and let me know if it is OK.
...tics/tracing/using-service-trace-viewer-for-viewing-correlated-traces-and-troubleshooting.md
Outdated
Show resolved
Hide resolved
.../framework/wcf/feature-details/how-to-create-a-workflow-service-with-messaging-activities.md
Outdated
Show resolved
Hide resolved
3. When the project is created, the Service1.xamlx file is opened in the designer as shown in the following illustration. | ||
|
||
 | ||
 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should specify what the screenshot is about in these alt texts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mairaw I've updated this one and the next (Messaging tab > Messaging section) based on your feedback. I'm not sure if I should make additional changes to the alt text content in the rest of this article. It seems that's what you're asking me to do. I'm just not sure what to change them to. Please provide guidance and I'll make the changes.
Can you look at the requested changes here @damabe? |
@mairaw Made the changes. Please review and provide feedback. Updated CATS: https://contentqacats.azurewebsites.net/CheckResults/2019032300028/Report/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thx @damabe!
Summary
Updating image file names and references to improve SEO.
Files #1463880
Contributes to #10839